Skip to content

Add purpur support for ServerLibraryCleaner#4133

Merged
itzg merged 2 commits into
itzg:masterfrom
harrisonablack:feat/serverLibraryCleanupPurpur
Jun 25, 2026
Merged

Add purpur support for ServerLibraryCleaner#4133
itzg merged 2 commits into
itzg:masterfrom
harrisonablack:feat/serverLibraryCleanupPurpur

Conversation

@harrisonablack

@harrisonablack harrisonablack commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Adds support for the ServerLibraryCleaner, implemented in itzg/mc-image-helper#748. Mimics implementation in #4046 by adding a variable, $CLEAN_SERVER_LIBRARIES which defaults to true.

Updated documentation to list support for TYPE=PURPUR

@itzg itzg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the progress

@itzg

itzg commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Build failure is just the sporadic exhaustion of GitHub token.

@itzg itzg changed the title feat: Add purpur support for ServerLibraryCleaner Add purpur support for ServerLibraryCleaner Jun 25, 2026
@itzg itzg merged commit 82043d5 into itzg:master Jun 25, 2026
6 of 7 checks passed
@harrisonablack

harrisonablack commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Build failure is just the sporadic exhaustion of GitHub token.

@itzg I was briefly looking at this, couldn't we get around rate limits by supplying a github token? From what i see currently we pass a github token to the test scripts, but the docker container never actually picks it up.

inside test/setuponlytest/test.sh, could we not just add -e GH_TOKEN to the docker compose run call?

@itzg

itzg commented Jun 26, 2026

Copy link
Copy Markdown
Owner

@harrisonablack oh, I think you're totally right. I had fixed it at both ends but hadn't realized it was missing the middle hop.

I'll make that change and see how that goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants